SyedM/crib
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 5 Wiki Activity

Rewrite diagnostics popup with new api

Browse Source
This commit is contained in:
Syed Daanish
2026-02-11 19:51:45 +00:00
parent 5b66f503e4
commit e9d164d769
10 changed files with 239 additions and 231 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
src/editor/worker.cc
View File

@@ -1,36 +1,33 @@
#include "editor/editor.h"
// void hover_diagnostic(Editor *editor) {
// static uint32_t last_line = UINT32_MAX;
// if (last_line == editor->cursor.row && !editor->warnings_dirty)
// return;
// VWarn dummy;
// dummy.line = editor->cursor.row;
// editor->warnings_dirty = false;
// last_line = editor->cursor.row;
// auto first =
// std::lower_bound(editor->warnings.begin(), editor->warnings.end(),
// dummy);
// auto last =
// std::upper_bound(editor->warnings.begin(), editor->warnings.end(),
// dummy);
// std::vector<VWarn> warnings_at_line(first, last);
// if (warnings_at_line.size() == 0) {
// editor->diagnostics_active = false;
// return;
// }
// editor->diagnostics.clear();
// editor->diagnostics.warnings.swap(warnings_at_line);
// editor->diagnostics.render_first();
// editor->diagnostics_active = true;
// }
void hover_diagnostic(Editor *editor) {
static uint32_t last_line = UINT32_MAX;
if (last_line == editor->cursor.row && !editor->warnings_dirty)
return;
VWarn dummy;
dummy.line = editor->cursor.row;
editor->warnings_dirty = false;
last_line = editor->cursor.row;
auto first =
std::lower_bound(editor->warnings.begin(), editor->warnings.end(), dummy);
auto last =
std::upper_bound(editor->warnings.begin(), editor->warnings.end(), dummy);
std::vector<VWarn> warnings_at_line(first, last);
if (warnings_at_line.size() == 0) {
editor->diagnostic_popup->hidden = true;
return;
}
editor->diagnostic_popup->clear();
editor->diagnostic_popup->warnings.swap(warnings_at_line);
editor->diagnostic_popup->hidden = false;
}
void Editor::work() {
if (!this->root)
return;
if (this->parser)
this->parser->work();
// hover_diagnostic(this);
hover_diagnostic(this);
// if (this->completion.active && this->completion.hover_dirty) {
// this->completion.hover.render_first();
// this->completion.hover_dirty = false;