From 95f2be311d27baf6587da221ae117cf58b901fa4 Mon Sep 17 00:00:00 2001
From: Daanish <me@syedm.dev>
Date: Sat, 28 Mar 2026 16:12:16 +0000
Subject: [PATCH] Refactor FPS display logic in Game class; optimize torch
 position retrieval

---
 assets/images/chest.aseprite | Bin 525 -> 531 bytes
 assets/images/chest.png      | Bin 367 -> 380 bytes
 game/placeables/base.rb      |  70 ++++++++++++++++++++++++-----------
 game/scene.rb                |  21 +++--------
 4 files changed, 53 insertions(+), 38 deletions(-)

diff --git a/assets/images/chest.aseprite b/assets/images/chest.aseprite
index 471db92417826af197d04a913472ebd6a35d73ab..8ca436ad66cb3fedde8261b7aecd8af4a8c17431 100644
GIT binary patch
delta 61
zcmeBWnasi{Jdv@Uaq`5*b&^jQ7#LU;7#J8B7#aREfoKpGVGy3|!MI!Ca6OmduF5M1
NW?ebPFfT^85dgPJ5VQaQ

delta 55
zcmbQt(#yigJCU)Tv3FwQI>~zs3=FIa3=9kmObq{-Kr{%8FbGZdVBF0Wx<PHLAw$Sd
GndJaaAq<@W

diff --git a/assets/images/chest.png b/assets/images/chest.png
index 72e75e43570539516a7ce389e39a8515ae7a5c9b..27d629aabcfb2c303c258577865f27e2348e275e 100644
GIT binary patch
delta 340
zcmaFQ^oMDJVZE8Bi(`mI@7gJb{)ZeS+T?x2l@4C=x}9L&v9a*N!GlL!#LW*Lv47}a
zP+as`{fD|tOl(40Ve)~iR~DrzCNAbHnm#S=qf+hUW%u{~eRs0@yK3vCP{E@|8)xS*
zz3R8qW^lVzvu8g`f>_vA1=D=K19uOv{<3Y_dk2YK2Cn%Nyfvii=gnh}I&gdT=NN`$
z&%EVlZI3@&@tEO*Ss&MH(XF1cJ55siVm?1Rb4V*Zz5UYXyU%V#@wjn@nEtU&tQRqq
z`E$?vi|N%{Z{C<aiCcI__SK=TD&Ek;rwi7wzL{H6bm5TZ?ljr!Yu2v~J;lqqAoJaW
z=-WkaqfJxS2B|$%@{CaV^`FBxG+!<8^tK;A`gYpgoqn(I)$c4>za*R0fjm<#c&?ec
zAvM~|o?(~6riYhVn@SGN3tMBa((pd@07D(a!ZoRz))Z$)FfcGMc)I$ztaD0e0s!tV
Brg{JX

delta 327
zcmeyv^qy&gVZElOi(`mIZ*qdfn+CyS8?Fod_wRIM&)<`hl8}&);3)QHRcRuK_2X01
zWDVyEm3_tr1_lOGOy4(l8#-qC&S2QsmKeCY^P$s>rpVX)f~g5n3uN1vBNnJ>D|35w
za~i)`-C+pQ5wqtrm%22shOt8B%q)hZr)`ApOYYnApg!fpwrg$OCp)?yr5;vdTitj=
zWWw7+&E|22b1Ydnr-$d?6J8qW<07z5oXz0SgowihD^m|HOZYs~+C}n3_M)aljdKxV
z;t!Gq#2*|!eT>aOskO1O(J`c9zN1@*^ttJRj}D$X#ugCs<Ng2ow)+2_`pO$tx)v^+
zvO(bR=I!q#{^(qBc#y>A@#)1I@%8r&JvcZYnF-{*cwO$YGr%i?!?{N=I&K-moz|Tn
f^rrHpFfbUag>Dp`Ui6lMfq}u()z4*}Q$iB}i<gdi

diff --git a/game/placeables/base.rb b/game/placeables/base.rb
index 73ec819..3e4f4d0 100644
--- a/game/placeables/base.rb
+++ b/game/placeables/base.rb
@@ -12,14 +12,6 @@ class Placeable
     @y = y
     @frames_count = 0
     @spritesheet = nil
-
-    $bus.on(:object_at) do |x, y|
-      next @x == x && @y == y ? self : nil
-    end
-
-    $bus.on(:collides?) do |rect|
-      next collides?(rect) ? :object : nil
-    end
   end
 
   def collides?(rect)
@@ -28,7 +20,7 @@ class Placeable
   end
 
   def rect
-    [@x * 120 + 90 - SIZE[0] / 2, @y * 120 + 90 - SIZE[1], SIZE[0], SIZE[1]]
+    [@x * 120 + 90 - SIZE[0] / 2, @y * 120 + 90 - SIZE[1], *SIZE]
   end
 
   def update
@@ -50,7 +42,7 @@ class Placeable
     return unless DEBUG
 
     # collision box centered on same point
-    Gosu.draw_rect(screen_x - SIZE[0] / 2, screen_y - SIZE[1], SIZE[0], SIZE[1], Gosu::Color.new(0x88ff0000), Float::INFINITY)
+    Gosu.draw_rect(screen_x - SIZE[0] / 2, screen_y - SIZE[1], *SIZE, Gosu::Color.new(0x88ff0000), Float::INFINITY)
   end
 end
 
@@ -67,16 +59,15 @@ class Torch < Placeable
     super(x, y)
     @frames_count = 4
     @spritesheet = Gosu::Image.load_tiles("assets/images/torch.png", 20, 20, retro: true)
-
-    $bus.on(:torch_position) do
-      next rect
-    end
   end
 end
 
 class Chest < Placeable
   def initialize(x, y)
     super(x, y)
+    @wood = rand(0..64)
+    @metal = rand(0..16)
+    @science = rand(0..4)
     @frames_count = 1
     @spritesheet = Gosu::Image.load_tiles("assets/images/chest.png", 20, 20, retro: true)
   end
@@ -86,16 +77,28 @@ class ObjectHandler
   attr_reader :objects
 
   def initialize
-    start_room_coords = $bus.get(:start_room_coords)
     @objects = []
+    @grid = {}
 
-    #spawn_chests!
+    spawn_chests!
+
+    $bus.on(:collides?) do |rect|
+      nearby_objects(rect).any? { |obj| obj.collides?(rect) } ? :object : nil
+    end
+
+    $bus.on(:object_at) do |x, y|
+      @grid[[x, y]]
+    end
+
+    $bus.on(:nearby_torches) do |rect|
+      nearby_objects(rect).select { |obj| obj.is_a?(Torch) }.map { |t| t.rect }
+    end
   end
 
   def spawn_chests!
     world_size = $bus.get(:maze_size) || [0, 0]
 
-    cell_size = 6  # tweak this (bigger = more spread out)
+    cell_size = 10
 
     (0...world_size[0]).step(cell_size) do |cx|
       (0...world_size[1]).step(cell_size) do |cy|
@@ -111,16 +114,38 @@ class ObjectHandler
 
         next if $bus.get(:room?, x, y)
 
-        # Chance per cell instead of per tile
-        if rand < 0.6
-          @objects << Chest.new(x, y)
-        end
+        chest = Chest.new(x, y)
+        @objects << chest
+        @grid[[x, y]] = chest
       end
     end
   end
 
+  def nearby_objects(rect)
+    x, y, w, h = rect
+
+    min_tx = ((x) / 120).floor
+    max_tx = ((x + w) / 120).floor
+    min_ty = ((y) / 120).floor
+    max_ty = ((y + h) / 120).floor
+
+    results = []
+
+    (min_tx..max_tx).each do |tx|
+      (min_ty..max_ty).each do |ty|
+        obj = @grid[[tx, ty]]
+        results << obj if obj
+      end
+    end
+
+    results
+  end
+
   def add(object)
     @objects << object
+
+    key = [object.x, object.y]
+    @grid[key] = object
   end
 
   def update
@@ -128,6 +153,7 @@ class ObjectHandler
   end
 
   def draw
-    @objects.each(&:draw)
+    cam = $bus.get(:camera_pos) || [0, 0]
+    nearby_objects([*cam, *SCREEN_SIZE]).each(&:draw)
   end
 end
\ No newline at end of file
diff --git a/game/scene.rb b/game/scene.rb
index c852589..4e5448c 100644
--- a/game/scene.rb
+++ b/game/scene.rb
@@ -44,20 +44,7 @@ class Game < Scene
   end
 
   def draw_debug!
-    now = Gosu.milliseconds
-    @last_draw_time ||= now
-    @draw_count ||= 0
-    @fps ||= 0
-
-    @draw_count += 1
-
-    if now - @last_draw_time >= 1000
-      @fps = @draw_count
-      @draw_count = 0
-      @last_draw_time = now
-    end
-
-    @font.draw_text("FPS: #{@fps}", 5, 5, Float::INFINITY, 1, 1, Gosu::Color::YELLOW)
+    @font.draw_text("FPS: #{Gosu.fps}", 5, 5, Float::INFINITY, 1, 1, Gosu::Color::YELLOW)
     world_x, world_y = $bus.get(:player_position)&.map(&:round) || [0, 0]
     @font.draw_text("Player: [#{world_x}, #{world_y}]", 5, 30, Float::INFINITY, 1, 1, Gosu::Color::YELLOW)
   end
@@ -79,8 +66,10 @@ class Game < Scene
     px = SCREEN_SIZE[0] / 2.0
     py = SCREEN_SIZE[1] / 2.0
 
-    # Collect all light sources (player + torches)
-    torches = $bus.get_all(:torch_position)
+    # Collect torch positions relative to camera
+    torches = $bus.get(:nearby_torches,
+      [cam_x - SCREEN_SIZE[0] / 2, cam_y - SCREEN_SIZE[1] / 2, SCREEN_SIZE[0] * 2, SCREEN_SIZE[1] * 2]
+    ) || []
     torch_lights = torches.map { |t| [t[0] - cam_x, t[1] - cam_y] }
 
     tiles_x = (SCREEN_SIZE[0] / cell) + 2