bugs and perfomance cleanup.

include/app/app.h

@@ -39,9 +39,7 @@ struct Element {
 struct EImage : Element {
   uint64_t animation_id = UINT64_MAX;
 
-  EImage(uint64_t animation_id) : Element(Type::IMAGE), animation_id(animation_id) {
-    animation_pool.use(animation_id);
-  }
+  EImage(uint64_t animation_id) : Element(Type::IMAGE), animation_id(animation_id) {}
 
   ~EImage() {
     if (animation_id != UINT64_MAX)
@@ -86,6 +84,13 @@ struct EText : Element {
     return window.get_text_size(text_id);
   }
 
+  void reload_text() {
+    if (text_id != UINT64_MAX) {
+      text_pool.release(text_id);
+      text_id = UINT64_MAX;
+    }
+  }
+
   void render(Window &window, uint64_t) override {
     if (
       last_language != Localization::current_language
@@ -93,13 +98,14 @@ struct EText : Element {
       || last_color != color
       || params_changed
     ) {
-      std::string localized_str = Localization::get(Ruby::mrb, key, params);
+      std::string localized_str = Localization::get(key, params);
       if (text_id != UINT64_MAX)
         text_pool.release(text_id);
       text_id = window.create_text(font_id, localized_str.c_str(), localized_str.size(), color);
       last_language = Localization::current_language;
       last_key = key;
       last_color = color;
+      params_changed = false;
     }
     window.write(text_id, position, z, rotation, pivot, scale, alpha);
   }

include/binding/definitions.h

@@ -65,6 +65,7 @@ static mrb_value params_set(mrb_state *mrb, mrb_value self) {
   app::EText *element = (app::EText *)app::element_pool[id];
 
   element->params[mrb_sym2name(mrb, key)] = mrb_str_to_cstr(mrb, mrb_obj_as_string(mrb, value));
+  element->reload_text();
 
   return mrb_nil_value();
 }
@@ -509,7 +510,7 @@ static mrb_value element_text_inspect(mrb_state *mrb, mrb_value self) {
 static mrb_value element_text_to_s(mrb_state *mrb, mrb_value self) {
   uint64_t id = get_id_ElementText(mrb, self);
   app::EText *element = (app::EText *)app::element_pool[id];
-  std::string localized_text = Localization::get(Ruby::mrb, element->key, element->params);
+  std::string localized_text = Localization::get(element->key, element->params);
   return mrb_str_new_cstr(mrb, localized_text.c_str());
 }
 
@@ -1173,6 +1174,7 @@ static mrb_value ElementImage_init(mrb_state *mrb, mrb_value self) {
   }
 
   uint64_t id = get_id_Animation(mrb, animation_val);
+  animation_pool.use(id);
 
   app::EImage *element = new app::EImage(id);
   element->position = {x, y};
@@ -1572,7 +1574,7 @@ static mrb_value scene_elements_at(mrb_state *mrb, mrb_value self) {
   mrb_value position_val;
   mrb_get_args(mrb, "o", &position_val);
 
-  float x, y;
+  float x = 0, y = 0;
   HASH_FLOAT(position_val, x, x);
   HASH_FLOAT(position_val, y, y);
   Vec2<float> position = {x, y};

include/binding/ruby.h

@@ -20,8 +20,6 @@
       out = mrb_float(v);           \
     else if (mrb_fixnum_p(v))       \
       out = (float)mrb_fixnum(v);   \
-    else                            \
-      out = 0;                      \
   } while (0)
 
 #define HASH_BOOL(h, key, out)      \

include/localization/localization.h

@@ -71,7 +71,7 @@ inline void set(LanguageCode lang_code, Key key, const std::string &text) {
   localized_strings[join_keys(lang_code, key)] = parse_localized(text);
 }
 
-inline std::string get(mrb_state *mrb, Key key, const std::unordered_map<std::string, std::string> &params) {
+inline std::string get(Key key, const std::unordered_map<std::string, std::string> &params) {
   auto it = localized_strings.find(join_keys(current_language, key));
   if (it == localized_strings.end())
     return "Localization not set!";

include/utils.h

@@ -163,6 +163,10 @@ struct Rect {
 
 template <typename T = void *>
 struct Pool {
+  uint32_t size() const {
+    return slots.size() - free_indices.size();
+  }
+
   T *operator[](uint64_t index) {
     if (!is_valid(index)) {
       fprintf(stderr, "Invalid pool index: %lu\n", (uint64_t)index);
@@ -191,7 +195,7 @@ struct Pool {
       slots.push_back({});
     }
     slots[id].ptr = item;
-    slots[id].refcount = 1;
+    slots[id].refcount = 0;
     slots[id].alive = true;
     slots[id].generation++;
     uint64_t index = ((uint64_t)slots[id].generation << 32) | id;